Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker_lite_push make target #16662

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix docker_lite_push make target #16662

merged 1 commit into from
Aug 27, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Aug 27, 2024 •
edited
Loading

Description

In #16042 I modified the make targets touching our vitess/lite docker image, and the push target is a bit broken, it only pushes suffixed images (percona80, etc) and not latest. This PR is a merge of what we had before + what was fixed in 16042.

Backporting this to 20.0 as the original PR was merge there too.

@frouioui
Fix docker_lite_push target
0f0e65a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui requested a review from deepthi as a code owner August 27, 2024 17:59
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 27, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 27, 2024
@frouioui frouioui added Type: CI/Build Component: Docker Backport to: release-20.0 Needs to be backport to release-20.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Aug 27, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 27, 2024
@deepthi deepthi merged commit 5633562 into vitessio:main Aug 27, 2024
142 checks passed
@deepthi deepthi deleted the fix-lite-push branch August 27, 2024 22:52
vitess-bot pushed a commit that referenced this pull request Aug 27, 2024
@vitess-bot @vitess-bot
Fix docker_lite_push make target (#16662)
7c8baa9 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot mentioned this pull request Aug 27, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (639b1de) to head (0f0e65a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16662      +/-   ##
==========================================
- Coverage   68.92%   68.90%   -0.02%     
==========================================
  Files        1562     1562              
  Lines      200855   200855              
==========================================
- Hits       138443   138405      -38     
- Misses      62412    62450      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frouioui pushed a commit that referenced this pull request Aug 28, 2024
@vitess-bot
[release-20.0] Fix docker_lite_push make target (#16662) (#16668)
b1eeefe 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
@frouioui @venkatraju
Fix docker_lite_push make target (vitessio#16662)
3fe4335 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@mattlord mattlord mattlord approved these changes

Assignees
No one assigned
Labels
Backport to: release-20.0 Needs to be backport to release-20.0 Component: Docker Type: CI/Build
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @deepthi @mattlord